James Fellows Yates
(james_fellows_yates@eva.mpg.de)
2021-01-19 20:17:22
@ivelsko https://github.com/SPAAM-community/AncientMetagenomeDir/pull/105 can we resolve this now as well with the info from Ana Phillips?
}
<p><strong>Pull Request</strong></p>
<p>This PR is for a</p>
<p>☑︎ <#new-publication|New Publication(s)>
☐ <#correction|Correction></p>
<p>For the follow list (s)</p>
<p>☐ Ancient Microbiome
☐ sedaDNA
☑︎ Ancient Pathogen</p>
<p><strong>New Publication</strong>
<strong>Publication Information</strong></p>
<p>This pull request is to add samples from the following publication(s):</p>
<p>Phillps et al. 2020 <a href="https://doi.org/10.1186/s12864-020-06810-9">https://doi.org/10.1186/s12864-020-06810-9</a></p>
<p>Note this reuses data from Philips 2017, but two of the <em>T. forsythia</em> genomes are from new data that has not been published.</p>
<p><strong>Checklist</strong></p>
<p>☑︎ Publication is published (preprints currently not accepted)?
☑︎ Checked the publication is not already in the database?
☑︎ Checked samples in this publication are not previously published <em>data</em> (newly re-sequenced metagenomes are OK!)?
☑︎ Samples are shotgun metagenomes?
☑︎ Checked the list follows conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)?
☐ (If applicable) Updated the JSON files under <code>/assets/enums</code> with new categories (e.g. material or archive)?
☑︎ Does your PR pass validation checks?
☑︎ Changelog is updated?</p>
<p>If you do not know how to check errors in failed validation checks, expand here</p>
<ol><li>Press 'details' next to the failed check.</li><li>Expand the <code>test ancient &lt;list&gt;</code> line with the red X next to it.</li><li>Scroll to the bottom of the log, and look for a <code>DatasetValidationError</code> (usually the last line).</li><li>Read the error, and fix accordingly. Check the README for a given list for more guidance. If in doubt, ask!</li>
</ol>
<p><strong>Correction</strong></p>
<p>This PR is for</p>
<p>☐ Ancient Microbiome
☐ sedaDNA
☐ Ancient Pathogen</p>
<p><strong>Reference</strong></p>
<p>This pull request is to correct samples from the following publication(s):</p>
<p><strong>Description</strong></p>
<p>The issue is:</p>
<p><strong>Checklist</strong></p>
<p>☐ Checked the corrected entries follow conventions as described in the corresponding sample type's README file (e.g. using ERS/SRS accession codes for ENA/SRA)
☐ Does your PR pass validation checks?
☐ Changelog is updated?</p>
James Fellows Yates
(james_fellows_yates@eva.mpg.de)
2021-01-20 11:16:10
*Thread Reply:* Yes please!
